Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make file download more intuitive #131

Closed
BertrandGouny opened this issue Mar 9, 2018 · 1 comment
Closed

Make file download more intuitive #131

BertrandGouny opened this issue Mar 9, 2018 · 1 comment

Comments

@BertrandGouny
Copy link

BertrandGouny commented Mar 9, 2018

  • flagrow/upload extension version: 0.6.0
  • flarum version: 0.1.0-beta.7

Hello,
thanks for this great pulgin,

I had one feedback from a user who thinks that it's a bit tricky to download a file:

  • we have to click on the button with the icon only.
  • other buttons just do nothing, that is confusing.

What do you think to make all buttons (icon, name, size) clickable to download a file ?

By the way it would be nice to add a classname to ButtonGroup in
/resources/templates/file.blade.php so customization would be easier :)

@luceos
Copy link
Contributor

luceos commented Mar 12, 2018

@BertrandGouny feel free to PR the classname to the file. Thanks for your feedback I'm aware the extension needs some love again. I'm tied up with another one for the time being, but I'll take the request along for the next overhaul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants