Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript breaking change in version 1.4.0 #73

Closed
mrlubos opened this issue May 20, 2021 · 1 comment
Closed

TypeScript breaking change in version 1.4.0 #73

mrlubos opened this issue May 20, 2021 · 1 comment
Assignees
@kyle-ssg

Comments

@mrlubos
Copy link

mrlubos commented May 20, 2021

The version 1.4.0 was meant to add an optional parameter to the identify() method like identify(userId:string, traits?: Record<string, string|number|boolean>), but the actual type is identify(userId:string, traits: Record<string, string|number|boolean>) which leads to compiler crashing when simply upgraded from version 1.3.0
@mrlubos mrlubos mentioned this issue May 20, 2021
Closed
@kyle-ssg
Copy link
Member

Ah yep, typo on my end should be fixed in 1.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyle-ssg kyle-ssg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kyle-ssg @mrlubos