Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WiFi doc , add two diagnostic words #55

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

nagy
Copy link

@nagy nagy commented Oct 4, 2023

The order in the documentation of WiFi.config is mixed up. This fixes the order. You can verify this for yourself with the accompanying diagnostic words.

Reference:

bool config(IPAddress local_ip,
            IPAddress gateway,
            IPAddress subnet,
            IPAddress dns1 = (uint32_t)0x00000000,
            IPAddress dns2 = (uint32_t)0x00000000);

https://github.com/espressif/arduino-esp32/blob/2.0.13/libraries/WiFi/src/WiFiSTA.h#L58

Reference:

```c
bool config(IPAddress local_ip,
            IPAddress gateway,
            IPAddress subnet,
            IPAddress dns1 = (uint32_t)0x00000000,
            IPAddress dns2 = (uint32_t)0x00000000);
```

https://github.com/espressif/arduino-esp32/blob/2.0.13/libraries/WiFi/src/WiFiSTA.h#L58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant