API requests are not made using a Session object #6
Comments
RobertD502
added a commit
to RobertD502/flair-api-client-py
that referenced
this issue
Jun 22, 2022
Utilize a requests `Session` object in the `Client` class to reuse TCP connection to Flair's servers instead of establishing a new connection for every request. Fixes flair-systems#6
RobertD502
added a commit
to RobertD502/flair-api-client-py
that referenced
this issue
Jun 22, 2022
Utilize a requests `Session` object in the `Client` class to reuse TCP connection to Flair's servers instead of creating a new connection for every request. Fixes flair-systems#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The code is using
requests.getdirectly without creating a session (https://requests.readthedocs.io/en/latest/user/advanced/#session-objects) which results in no HTTP Keep-Alive or connection pooling. This means the API client is creating and tearing down a TCP connection for each request, potentially resulting in worse performance for users of the client. Seeflair-api-client-py/flair_api/client.py
Line 191 in d928840
The text was updated successfully, but these errors were encountered: