Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close log_handler after training is complete. #2169

Closed
parakalan opened this issue Mar 19, 2021 · 0 comments · Fixed by #2170
Closed

Close log_handler after training is complete. #2169

parakalan opened this issue Mar 19, 2021 · 0 comments · Fixed by #2170
Labels
bug Something isn't working

Comments

@parakalan
Copy link

Describe the bug
We are removing the log_handler here but not closing the handler leading to ResourceWarning: unclosed file <_io.BufferedReader name='training.log. Hence we are not able to programatically access the training.log (For ex - Unable to upload the file to s3 using botocore)

To Reproduce
Training just any model leads to this Warning.

Expected behavior
The log_handler to be closed before training exits

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • MacOS 10.15.6
  • Version: flair-0.8
@parakalan parakalan added the bug Something isn't working label Mar 19, 2021
@parakalan parakalan mentioned this issue Mar 19, 2021
Merged
alanakbik added a commit that referenced this issue Apr 7, 2021
@alanakbik
Merge pull request #2170 from parakalan/master
b379709 
GH-2169 - Close log_handler after training is complete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-2169 - Close log_handler after training is complete. parakalan/flair
1 participant
@parakalan