Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to update sentencepiece requirement to 0.1.96 #2833

Closed
tobiasb96 opened this issue Jun 23, 2022 · 6 comments · Fixed by #2835
Closed

Request to update sentencepiece requirement to 0.1.96 #2833

tobiasb96 opened this issue Jun 23, 2022 · 6 comments · Fixed by #2835

Comments

@tobiasb96
Copy link

Dear Flair developers,

we have noticed a minor version complication when installing Flair on our machines. We are using Python 3.10 and encountered the problem of sentencepiece not being installed properly due to a missing wheel on PyPi.

They released the version 0.1.96 last year which should contain minor, non-breaking changes according to their release notes. They have only published the builts for 0.1.95 for Python <= 3.9. Therefore we have to use a workaround when installing flair with Python 3.10.

Maybe it's possible to upgrade the version of sentencepiece in the requirements.txt or turn it into a "loose" requirement?

Thanks for your help!

@bastianwegge
Copy link

@alanakbik sorry to bug you with a closed issue, but is there a chance to get a patch-release for this? Maybe something like 0.11.1?

@alanakbik
Copy link
Collaborator

Hello @bastianwegge we've made some bigger changes so we'll likely release a 0.12.0 version in a few weeks (that will drop Python 3.6 support). In the meantime, you could install directly from master branch to get this fix.

@bastianwegge
Copy link

Thanks a lot for the update! We're looking forward to using 0.12.0 🙌

@sbwiecko
Copy link

Thank you @alanakbik, pip install git+https://github.com/flairNLP/flair solved the issue on my installation 👍

@Snowpile
Copy link

Dear Flair developers,

we have noticed a minor version complication when installing Flair on our machines. We are using Python 3.10 and encountered the problem of sentencepiece not being installed properly due to a missing wheel on PyPi.

They released the version 0.1.96 last year which should contain minor, non-breaking changes according to their release notes. They have only published the builts for 0.1.95 for Python <= 3.9. Therefore we have to use a workaround when installing flair with Python 3.10.

Maybe it's possible to upgrade the version of sentencepiece in the requirements.txt or turn it into a "loose" requirement?

Thanks for your help!

What was your work around for installing with Python 3.10?

@tobiasb96
Copy link
Author

@Snowpile
We currently use the (ugly) solution of installing flair without dependencies and adding the required dependencies as well as the correct sentencepiece version (0.1.96) to our own requirements.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants