Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes,
start_pos
inToken
is set to None.This is for instance the case when loading a
Corpus
in columnar format.In those cases
while t.start_pos != pos
fromto_original_text
method is always True.This fix manages this case.
Another solution would be to just throw an Exception. Let me know what you prefer. In this case it may be good to forbid to have
start_pos
beingNone
in any case and to rewriteCorpus
class. May be to put in another PR