Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $HOME instead of ~ for cache_root #1134

Merged
merged 1 commit into from Sep 20, 2019

Conversation

severinsimmler
Copy link
Contributor

@severinsimmler severinsimmler commented Sep 19, 2019

The directory .flair is created in the home directory, which is currently determined with ~ and os.path.expanduser().

The home() classmethod of a pathlib.Path object determines the home directory via the $HOME environment variable --- which can easily be modified (makes sense, for example, on an Elastic Beanstalk instance where there is no user and no home folder).

However, I think pathlib is widely used in this beautiful library, so it would even make sense for consistency reasons :)

@alanakbik
Copy link
Collaborator

@severinsimmler thanks - makes sense :)

@alanakbik
Copy link
Collaborator

👍

1 similar comment
@yosipk
Copy link
Collaborator

yosipk commented Sep 20, 2019

👍

@alanakbik alanakbik merged commit 9904842 into flairNLP:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants