New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add DocumentCNNEmbeddings #2141

Merged

alanakbik merged 1 commit into flairNLP:master from djstrong:cnn_embeddings

Mar 13, 2021

Contributor

djstrong commented Mar 9, 2021 •

edited

Loading

I have implemented a simple CNN document embeddings based on Kim's CNN model.

Tests on TREC_6 give worse results than using RNN.

However, I am not sure if all code copied from DocumentRNNEmbeddings make sense in CNN.

djstrong mentioned this pull request

Whether to consider adding Attention-mechanism or CNN module? #395

Closed


          add DocumentCNNEmbeddings

2bb1a73

djstrong force-pushed the cnn_embeddings branch from ab97ce5 to 2bb1a73 Compare

March 9, 2021 10:53

Collaborator

alanakbik commented Mar 13, 2021

@djstrong thanks for adding this!

alanakbik merged commit b415155 into flairNLP:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment