do not save Path objects to model cards #2998
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving
Path
objects in Pickle can lead to OS incompatibilities, asPath
is resolved to eitherPosixPath
(linux) orWindowsPath
(windows).As the model card saves the training parameters, calling with a path can lead that models trained on a linux docker won't be loadable on any Windows machine (and reversed).
This PR gives a simple fix by converting each path to a string before adding it to the ModelCard