Allow to keep token embeddings after SequenceTagger.predict() #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dict() method. This parameter controls the cleaning of token embeddings after the prediction. Setting it to false allows to retrieve the token embeddings for reuse.
|
@khituras the build was failing due to not passing the code formatting checks performed by black. I've corrected and hopefully it runs through now. Will merge then! |
|
Aw, I forgot about that part, I meant to check via black myself. Sorry about that! |
|
No worries - I'm actually thinking of perhaps removing the formatter again as it seems to be causing confusion. |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #784. A new parameter
clear_word_embeddingswas added toSequenceTagger.predict()which is just connected through toclear_embeddingsmethod that already has this parameter.Since the embeddings are also cleared at the beginning of the
predictmethod, there should be no issue with embeddings bleeding through the usage of multiple models on the same sentence/tokens.I added a small test to show that the new parameter works as intended.
I hopy everything is fine with the PR, let me know!