Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Which ALPHA code should I use for the country India? #528

Closed
Senthi1Kumar opened this issue May 30, 2024 · 2 comments
Closed
Labels
question Further information is requested

Comments

@Senthi1Kumar
Copy link

Question

Hi there,

As I'm creating a new publisher for The Hindu from India and working on a Parser stub, I've encountered an issue with the alpha-2 code for India, which is IN. This code conflicts with the in keyword in Python, leading to a syntax error. Therefore, I propose using the alternate alpha-3 code IND to avoid this conflict. If we go with this naming convention, any other publishers for India will fall under fundus/publishers/ind.

Also, I've looked into the country codes with is keyword and found that the alpha-2 code for Iceland is IS, while the alpha-3 code is ISL. Therefore, any future publisher for Iceland would be located under ../../isl.

@Senthi1Kumar Senthi1Kumar added the question Further information is requested label May 30, 2024
@MaxDall
Copy link
Collaborator

MaxDall commented May 30, 2024

@Senthi1Kumar That's a really good point and idea 👍 For now, I think the best would be to proceed as you suggested, using the alpha-3 code for India.

I will think about replacing the current alpha-2 code with alpha-2 ones, but this may take a while.

@Senthi1Kumar
Copy link
Author

Thank you @MaxDall for the approval, I'll go with ind code and finish that first publisher :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants