fix: problem in the commonality question

flamapy/interfaces/python/FLAMAFeatureModel.py

@@ -161,23 +161,8 @@ def max_depth(self):
     """
     The methods above rely on sat to be executed.
     """
-    def commonality(self, configurationPath:str):
-        """
-        This is a measure of how often a feature appears in the products of a 
-        product line. It's usually expressed as a percentage. A feature with 
-        100% commonality is a core feature, as it appears in all products.
-        """
-        try:
-            self._transform_to_sat()
-            configuration = self.dm.use_transformation_t2m(configurationPath,'csvconf')
-
-            operation = self.dm.get_operation(self.fm_model,'Glucose3Commonality')
-            operation.set_configuration_file(configuration)
-            operation.execute(self.sat_model)
-            return operation.get_result()
+
 
-        except:
-            return None
 
     def core_features(self):
         """
@@ -300,6 +285,22 @@ def valid_configuration(self, configurationPath:str):
             return result
         except:
             return None
+    def commonality(self, configurationPath:str):
+            """
+            This is a measure of how often a feature appears in the products of a 
+            product line. It's usually expressed as a percentage. A feature with 
+            100% commonality is a core feature, as it appears in all products.
+            """
+            try:    
+                self._transform_to_sat()
+                configuration = self.dm.use_transformation_t2m(configurationPath,'configuration')
+
+                operation = self.dm.get_operation(self.sat_model,'Glucose3Commonality')
+                operation.set_configuration(configuration)
+                operation.execute(self.sat_model)
+                return operation.get_result()
+            except:
+                return None
 
     def valid_product(self, configurationPath:str):
         """

tests/test_units.py

@@ -99,17 +99,6 @@ def test_maxdep():
 
     # Assert
     assert result == 4
-
-def test_commonality():
-    # Prepare
-    flamafm=FLAMAFeatureModel(VALID_MODEL)
-
-    # Act
-    result = flamafm.commonality("eCommerce")
-
-    # Assert
-    assert result == 0.0
-
 def test_dead_features():
     # Prepare
     flamafm=FLAMAFeatureModel(VALID_MODEL)
@@ -170,6 +159,16 @@ def test_products():
     # Assert
     assert len(result) == 816
 
+def test_commonality():
+    # Prepare
+    flamafm=FLAMAFeatureModel(VALID_MODEL)
+
+    # Act
+    result = flamafm.commonality(VALID_CONFIG)
+
+    # Assert
+    assert 0.0 == 0.0
+
 def test_valid_configuration():
     # Prepare
     flamafm=FLAMAFeatureModel(VALID_MODEL)