feat: Add avoid_final_parameters, depend_on_referenced_packages, unne…

…cessary_to_list_in_spreads (#1927) Adds these three sensible rules: avoid_final_parameters depend_on_referenced_package unnecessary_to_list_in_spreads
flame-engine · Sep 20, 2022 · deccb43 · deccb43
1 parent f4e8af2
commit deccb43
Show file tree

Hide file tree

Showing 12 changed files with 17 additions and 21 deletions.
diff --git a/examples/games/padracing/pubspec.yaml b/examples/games/padracing/pubspec.yaml
@@ -7,6 +7,7 @@ environment:
   sdk: ">=2.17.0 <3.0.0"
 
 dependencies:
+  collection: ^1.16.0
   flame: ^1.3.0
   flame_forge2d: ^0.12.2
   flutter:

diff --git a/examples/games/trex/pubspec.yaml b/examples/games/trex/pubspec.yaml
@@ -10,6 +10,7 @@ environment:
   flutter: ">=3.3.0"
 
 dependencies:
+  collection: ^1.16.0
   flame: ^1.3.0
   flutter:
     sdk: flutter

diff --git a/examples/lib/stories/bridge_libraries/forge2d/generated_plugin_registrant.dart b/examples/lib/stories/bridge_libraries/forge2d/generated_plugin_registrant.dart
diff --git a/examples/pubspec.yaml b/examples/pubspec.yaml
@@ -18,6 +18,7 @@ dependencies:
   flutter:
     sdk: flutter
   google_fonts: ^2.3.2
+  meta: ^1.8.0
   padracing:
     path: games/padracing
   trex_game:

diff --git a/packages/flame_bloc/example/pubspec.yaml b/packages/flame_bloc/example/pubspec.yaml
@@ -10,6 +10,7 @@ environment:
 
 dependencies:
   equatable: ^2.0.3
+  flame: ^1.3.0
   flame_bloc: ^1.7.0
   flutter:
     sdk: flutter
@@ -20,7 +21,6 @@ dev_dependencies:
   flutter_test:
     sdk: flutter
 
-
 flutter:
   uses-material-design: true
   assets:

diff --git a/packages/flame_flare/example/pubspec.yaml b/packages/flame_flare/example/pubspec.yaml
@@ -10,6 +10,7 @@ environment:
 dependencies:
   flame: ^1.3.0
   flame_flare: ^1.4.0
+  flare_flutter: ^3.0.2
   flutter:
     sdk: flutter
 

diff --git a/packages/flame_lint/lib/analysis_options.yaml b/packages/flame_lint/lib/analysis_options.yaml
@@ -23,6 +23,7 @@ linter:
     - avoid_equals_and_hash_code_on_mutable_classes
     - avoid_escaping_inner_quotes
     - avoid_field_initializers_in_const_classes
+    - avoid_final_parameters
     - avoid_init_to_null
     - avoid_js_rounded_ints
     - avoid_null_checks_in_equality_operators
@@ -48,6 +49,7 @@ linter:
     - constant_identifier_names
     - control_flow_in_finally
     - curly_braces_in_flow_control_structures
+    - depend_on_referenced_packages
     - deprecated_consistency
     - directives_ordering
     - do_not_use_environment
@@ -140,6 +142,7 @@ linter:
     - unnecessary_string_escapes
     - unnecessary_string_interpolations
     - unnecessary_this
+    - unnecessary_to_list_in_spreads
     - unrelated_type_equality_checks
     - unsafe_html
     - use_enums

diff --git a/packages/flame_svg/pubspec.yaml b/packages/flame_svg/pubspec.yaml
@@ -20,4 +20,4 @@ dev_dependencies:
   dartdoc: ^6.0.1
   flame_lint: ^0.1.2
   mocktail: ^0.3.0
-  test: ^1.17.12
+  test: any
diff --git a/packages/flame_test/example/pubspec.yaml b/packages/flame_test/example/pubspec.yaml
@@ -15,6 +15,10 @@ dependencies:
 dev_dependencies:
   flame_lint: ^0.1.2
   flame_test: ^1.7.0
+  flutter_test:
+    sdk: flutter
+  test: any
+
 flutter:
   assets:
     - assets/images/
diff --git a/packages/flame_test/pubspec.yaml b/packages/flame_test/pubspec.yaml
@@ -17,7 +17,7 @@ dependencies:
   flutter_test:
     sdk: flutter
   meta: ^1.7.0
-  test: ^1.17.12
+  test: any
   vector_math: ^2.1.1
 
 dev_dependencies:

diff --git a/packages/flame_tiled/example/pubspec.yaml b/packages/flame_tiled/example/pubspec.yaml
@@ -11,9 +11,11 @@ dependencies:
   flame_tiled: ^1.7.2
   flutter:
     sdk: flutter
+  tiled: ^0.8.4
 
 dev_dependencies:
   flame_lint: ^0.1.2
+
 flutter:
   uses-material-design: true
   assets:

diff --git a/tutorials/space_shooter/pubspec.yaml b/tutorials/space_shooter/pubspec.yaml
@@ -15,6 +15,7 @@ dependencies:
     sdk: flutter
   flutter_highlight: ^0.7.0
   flutter_markdown: ^0.6.7
+  markdown: ^6.0.0
 
 dev_dependencies:
   flame_lint: ^0.1.2