fix: Change to FilterQuality.medium instead of high (#2733)

According to the Flutter docs, tests and #2551 FilterQuality.high is actually producing worse output than FilterQuality.medium in almost all cases (the exception is when you use a very high scale factor). This PRs set the places we have defined as high to medium instead.
flame-engine · Sep 12, 2023 · fc19890 · fc19890
1 parent 8726d03
commit fc19890
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 2 deletions.
diff --git a/packages/flame/lib/src/components/text_box_component.dart b/packages/flame/lib/src/components/text_box_component.dart
@@ -48,7 +48,7 @@ class TextBoxConfig {
 
 class TextBoxComponent<T extends TextRenderer> extends TextComponent {
   static final Paint _imagePaint = BasicPalette.white.paint()
-    ..filterQuality = FilterQuality.high;
+    ..filterQuality = FilterQuality.medium;
   final TextBoxConfig _boxConfig;
   final double pixelRatio;
 

diff --git a/packages/flame/test/_goldens/sprite_font_renderer_1.png b/packages/flame/test/_goldens/sprite_font_renderer_1.png
diff --git a/packages/flame/test/_goldens/text_box_component_test_1.png b/packages/flame/test/_goldens/text_box_component_test_1.png
diff --git a/packages/flame_svg/lib/svg.dart b/packages/flame_svg/lib/svg.dart
@@ -23,7 +23,7 @@ class Svg {
 
   final MemoryCache<Size, Image> _imageCache = MemoryCache();
 
-  final _paint = Paint()..filterQuality = FilterQuality.high;
+  final _paint = Paint()..filterQuality = FilterQuality.medium;
 
   final List<Size> _lock = [];
 

diff --git a/packages/flame_svg/test/_goldens/render_sharply.png b/packages/flame_svg/test/_goldens/render_sharply.png