-
-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: flame_tiled - add centered anchor point for tile rotation #1570
Conversation
add centered anchor for rotations
Update renderable_tile_map.dart
Some tests are failing, due to the update. It looks like the code change is sound, but that the tests need to be updated. |
I guess the only other question I have is whether this solves the issue described at the top of the README for this package and if I should remove that note with this PR? Changing:
to something like:
|
Have you tried whether flips work? If they do agree the readme change sounds good. |
It doesn't fix flips - just rotations. I had a map with random flips and rotations - the rotations stuck out as broken because they were drawn in the wrong location. I assumed that flips were broken similarly but a quick test with just flipped tiles shows that is a different problem. |
Good to know, then we'll merge this and see if someone fixes flips in the future |
Description
Added a centered anchor point to SpriteBatch creation so that rotations won't move tiles into the wrong position.
Checklist
fix:
,feat:
,docs:
etc).docs
and added dartdoc comments with///
.examples
.Breaking Change
Related Issues
I'm assuming this fixes the errant behavior described at the top of the project readme? There wasn't a lot of detail. With this patch rotations work in my project.