Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove onTimingsCallback for Flutter 3.0 #1626

Merged
merged 1 commit into from May 15, 2022

Conversation

wolfenrain
Copy link
Contributor

@wolfenrain wolfenrain commented May 14, 2022

Description

This technically speaking is a breaking change, but since we are already planning on deprecating the FPSCounter the team has internally decided to turn the fps() method into a copy of the functionality from #1595 so that we can remove the method onTimingsCallback already so Flutter 3.0 users wont have any warnings. This method is either not used or a really small portion of people are using it, compared to the FPSCounter.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change, but as we are doing this on purpose I have not added the suffix !.
  • No, this is not a breaking change.

Related Issues

@st-pasha
Copy link
Contributor

👍 to this change - even with the old FpsCounter it was unclear why the method was exposed in the Game's API, since it was possible to subscribe to the timing events from the mixing itself.

this is a breaking change, but as we are doing this on purpose I have not added the suffix !.

That doesn't sound right though. All breaking changes that we do are deliberate, and are marked with !. Of course, there could be some breaking changes that we introduced without noticing, by accident - those will have no !.

@wolfenrain wolfenrain changed the title feat: remove onTimingsCallback for Flutter 3.0 feat!: remove onTimingsCallback for Flutter 3.0 May 15, 2022
@spydon spydon merged commit 0761a79 into main May 15, 2022
@spydon spydon deleted the feat/remove-on-timing-callback-for-flutter-3 branch May 15, 2022 14:19
st-pasha pushed a commit to st-pasha/flame that referenced this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants