feat: Animated tile support! #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
converting to draft: more tests!
|
|
Possible further optimization from discord chat:
|
spydon
approved these changes
Sep 23, 2022
Comment on lines
6
to
7
| MutableRect.fromLTRB(this.left, this.top, this.right, this.bottom) | ||
| : super.fromLTRB(left, top, right, bottom); // must call? |
Need to remember to update it to the newest version of Flame_tiled when it's available. |
The examples are managed by Melos, so Melos should be updating it automatically once we release a new version. |
Tiled supports animated tiles, so should Flame. Fixes flame-engine#1914
- markdownlint.yaml was invalid yaml(???!!) - but now works in vscode! - fixed my markdown
I'm rendering 4x1 isometrics wrong - need to fix that before finishing
- Update animationFrames first, memoizing the frame tracking work - Then update the batch tiles if they were updated.
jtmcdole
force-pushed
the
aniamtedTiles
branch
from
62a8d93
to
6c17b95
Compare
done! |
erickzanardo
approved these changes
Sep 23, 2022
| @@ -38,6 +39,7 @@ void main() { | |||
| addInputStories(dashbook); | |||
| addParallaxStories(dashbook); | |||
| addRenderingStories(dashbook); | |||
| addTiledStories(dashbook); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tiled supports animated tiles, and now Flame does as well...
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #1914
Fixes #1932