-
-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Animated tile support! #1930
Conversation
converting to draft: more tests!
|
Possible further optimization from discord chat:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Would be good to have an example for the examples directory too.
MutableRect.fromLTRB(this.left, this.top, this.right, this.bottom) | ||
: super.fromLTRB(left, top, right, bottom); // must call? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comment?
Need to remember to update it to the newest version of Flame_tiled when it's available. |
The examples are managed by Melos, so Melos should be updating it automatically once we release a new version. |
Tiled supports animated tiles, so should Flame. Fixes flame-engine#1914
- markdownlint.yaml was invalid yaml(???!!) - but now works in vscode! - fixed my markdown
I'm rendering 4x1 isometrics wrong - need to fix that before finishing
- Update animationFrames first, memoizing the frame tracking work - Then update the batch tiles if they were updated.
62a8d93
to
6c17b95
Compare
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
@@ -38,6 +39,7 @@ void main() { | |||
addInputStories(dashbook); | |||
addParallaxStories(dashbook); | |||
addRenderingStories(dashbook); | |||
addTiledStories(dashbook); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Description
Tiled supports animated tiles, and now Flame does as well...
Checklist
fix:
,feat:
,docs:
etc).docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues
Closes #1914
Fixes #1932