Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding posibility to execute future once component is removed. #2080

Merged
merged 14 commits into from
Oct 17, 2022
Merged

feat: Adding posibility to execute future once component is removed. #2080

merged 14 commits into from
Oct 17, 2022

Conversation

idlehart
Copy link
Contributor

@idlehart idlehart commented Oct 14, 2022 •
edited
Loading

Description

This corresponds to mounted/isMounted lifecycle event but for the removed state.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [] I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #1956

Joakim Sjöstedt and others added 3 commits October 6, 2022 20:27
Added possibility to complete a future once a component is removed.
78774f8 
Signed-off-by: Joakim Sjöstedt <joakim.sjostedt@skandia.se>
Refactor, docs, unit-tests.
8c7c9ac 
Signed-off-by: Joakim Sjöstedt <joakim.sjostedt@skandia.se>
@idlehart
Merge branch 'flame-engine:main' into main
a8a1224
@spydon spydon requested a review from st-pasha October 14, 2022 20:38
idlehart and others added 2 commits October 15, 2022 00:16
@idlehart @spydon
Update packages/flame/lib/src/components/core/component.dart
c129ef2 
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@idlehart @spydon
Update packages/flame/lib/src/components/core/component.dart
bfb2b93 
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Joakim Sjöstedt and others added 2 commits October 15, 2022 14:11
Make sure lifecycleManager is alive until _removedCompleter has compl…
8473f11 
…eted and been set to null.

Signed-off-by: Joakim Sjöstedt <joakim.sjostedt@skandia.se>
@idlehart
Merge branch 'main' into main
3bf5d45
@idlehart
Copy link
Contributor Author

idlehart commented Oct 16, 2022 •
edited
Loading

Not sure why the trex_game is failing the pipline at the moment. Is there a known issue?

@spydon
Copy link
Member

spydon commented Oct 16, 2022

Not sure why the trex_game is failing the pipline at the moment. Is there a known issue?

It failed to get some dependencies or something for it, it became green when I re-ran it.

st-pasha
st-pasha approved these changes Oct 17, 2022
View reviewed changes
packages/flame/test/components/component_test.dart Outdated Show resolved Hide resolved
packages/flame/lib/src/components/core/component.dart Outdated Show resolved Hide resolved
packages/flame/lib/src/components/core/component.dart Outdated Show resolved Hide resolved
packages/flame/lib/src/components/core/component.dart Outdated Show resolved Hide resolved
idlehart and others added 6 commits October 17, 2022 09:05
@idlehart @st-pasha
Update packages/flame/test/components/component_test.dart
c300ed5 
Co-authored-by: Pasha Stetsenko <stpasha@gmail.com>
@idlehart @st-pasha
Update packages/flame/lib/src/components/core/component.dart
2eba9f5 
Co-authored-by: Pasha Stetsenko <stpasha@gmail.com>
@idlehart @st-pasha
Update packages/flame/lib/src/components/core/component.dart
13630e5 
Co-authored-by: Pasha Stetsenko <stpasha@gmail.com>
@idlehart @st-pasha
Update packages/flame/lib/src/components/core/component.dart
1ce7232 
Co-authored-by: Pasha Stetsenko <stpasha@gmail.com>
@idlehart
Merge branch 'main' into main
107ef12
Test scenario string to long.
941704a 
Signed-off-by: Joakim Sjöstedt <joakim.sjostedt@skandia.se>
@spydon spydon enabled auto-merge (squash) October 17, 2022 07:30
@spydon spydon merged commit 9f32278 into flame-engine:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@erickzanardo erickzanardo erickzanardo approved these changes

@st-pasha st-pasha st-pasha approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Component.removed
4 participants
@idlehart @spydon @erickzanardo @st-pasha