Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Re-use paint object in ImageParticle #2210

Merged
merged 1 commit into from
Dec 2, 2022
Merged

fix: Re-use paint object in ImageParticle #2210

merged 1 commit into from
Dec 2, 2022

Conversation

spydon
Copy link
Member

@spydon spydon commented Dec 2, 2022

Description

Since it is very bad to create paint-objects in the render loop this PR moves out the paint object and lets the user set the paint object manually.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@spydon spydon requested a review from a team December 2, 2022 21:06
@spydon spydon merged commit 7a945d9 into main Dec 2, 2022
@spydon spydon deleted the spydon/reuse-paint-image-particle branch December 2, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spydon @erickzanardo