Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Solve warnings from 3.10.0 analyzer #2532

Merged
merged 10 commits into from May 14, 2023
Merged

Conversation

spydon
Copy link
Member

@spydon spydon commented May 11, 2023

Description

Just solves the warnings that the new Flutter version complains about (which makes us lose 10 points on pub).

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@spydon spydon enabled auto-merge (squash) May 11, 2023 11:09
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, the new image looks quite different compared to the old one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because it was generated on macOS instead of Linux probably, I'll generate them on Linux when I get home. :)

@spydon spydon merged commit b41622d into main May 14, 2023
6 checks passed
@spydon spydon deleted the spydon/fix-analysis-3.10 branch May 14, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants