refactor: Enable DCM linting #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incendial
reviewed
Aug 21, 2023
6 tasks
luanpotter
changed the title
luanpotter
commented
Aug 24, 2023
| @@ -42,6 +42,24 @@ jobs: | |||
| node-version: 18 | |||
| - run: npm install -g markdownlint-cli | |||
| - run: markdownlint . -p .markdownlintignore -c .markdownlint.yaml | |||
|
|
|||
| dcm: | |||
There was a problem hiding this comment.
I can make it mandatory once this merges
luanpotter
commented
Aug 24, 2023
| # dart rules | ||
| - avoid-banned-imports | ||
| # flutter rules | ||
| - prefer-define-hero-tag |
There was a problem hiding this comment.
just the first for each from the all preset
luanpotter
added a commit
that referenced
this pull request
Aug 24, 2023
Fix a couple lint issues across the codebase, identified by #2667 Nothing controversial, I expect; getting these out of the way so we can focus on discussing bigger things.
spydon
approved these changes
Aug 24, 2023
erickzanardo
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards enabling DCM for Flame. Though I have tested with all rules, and am working on selecting, assessing, and fixing violations, as a first step, we can merge the infrastructural changes to flame_lint to and GitHub actions.
As a proof of concept, I am enabling two rules for which we have no violations.
I will followup with enabling more rules, adding discussions for controversial changes, and fixing non-controversial violations.