Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Enable DCM linting #2667

Merged
merged 20 commits into from Aug 24, 2023
Merged

refactor: Enable DCM linting #2667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
3001547
[WIP] Try out DCM
luanpotter Aug 20, 2023
13bd737
.
luanpotter Aug 20, 2023
bc982f1
.
luanpotter Aug 20, 2023
7278f1c
.
luanpotter Aug 20, 2023
5e95b1b
.
luanpotter Aug 20, 2023
6e97054
.
luanpotter Aug 20, 2023
3bd81d7
.
luanpotter Aug 20, 2023
c2f03e5
.
luanpotter Aug 20, 2023
6440a90
.
luanpotter Aug 20, 2023
49752cc
Properly wire up analysis options
luanpotter Aug 21, 2023
eefd6c7
.
luanpotter Aug 21, 2023
d31348c
.
luanpotter Aug 21, 2023
6c22018
.
luanpotter Aug 22, 2023
3fb79fa
Explicitly add rules
luanpotter Aug 23, 2023
cebe66a
Fixes
luanpotter Aug 24, 2023
6956972
Fix
luanpotter Aug 24, 2023
ddf5121
Fix
luanpotter Aug 24, 2023
75746d5
Simplify
luanpotter Aug 24, 2023
166f2e6
Fix
luanpotter Aug 24, 2023
f57e8f1
Merge branch 'main' into luan.dcm
luanpotter Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/cicd.yml
View file
Open in desktop
Expand Up @@ -42,6 +42,24 @@ jobs:
node-version: 18
- run: npm install -g markdownlint-cli
- run: markdownlint . -p .markdownlintignore -c .markdownlint.yaml

dcm:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make it mandatory once this merges

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: subosito/flutter-action@v2
with:
flutter-version: '3.13.0'
channel: 'stable'
- uses: bluefireteam/melos-action@v2

- name: Install DCM
uses: CQLabs/setup-dcm@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}

- name: Run DCM
run: dcm analyze .
# END LINTING STAGE

# BEGIN TESTING STAGE
Expand Down
2 changes: 1 addition & 1 deletion doc/flame/examples/analysis_options.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml

linter:
rules:
Expand Down
2 changes: 1 addition & 1 deletion doc/tutorials/klondike/app/analysis_options.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml

linter:
rules:
Expand Down
2 changes: 1 addition & 1 deletion doc/tutorials/platformer/app/analysis_options.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml

linter:
rules:
Expand Down
2 changes: 1 addition & 1 deletion doc/tutorials/space_shooter/app/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion examples/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion examples/games/padracing/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion examples/games/rogue_shooter/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion examples/games/trex/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame/example/analysis_options.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml

linter:
rules:
Expand Down
2 changes: 1 addition & 1 deletion packages/flame_audio/analysis_options.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml

linter:
rules:
Expand Down
2 changes: 1 addition & 1 deletion packages/flame_audio/example/analysis_options.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml

linter:
rules:
Expand Down
2 changes: 1 addition & 1 deletion packages/flame_bloc/analysis_options.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml

linter:
rules:
Expand Down
2 changes: 1 addition & 1 deletion packages/flame_bloc/example/analysis_options.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml

linter:
rules:
Expand Down
2 changes: 1 addition & 1 deletion packages/flame_fire_atlas/analysis_options.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml

linter:
rules:
Expand Down
2 changes: 1 addition & 1 deletion packages/flame_fire_atlas/example/analysis_options.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml

linter:
rules:
Expand Down
2 changes: 1 addition & 1 deletion packages/flame_forge2d/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame_forge2d/example/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame_isolate/analysis_options.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml

linter:
rules:
Expand Down
2 changes: 1 addition & 1 deletion packages/flame_isolate/example/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame_jenny/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame_jenny/jenny/analysis_options.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml

linter:
rules:
Expand Down
2 changes: 1 addition & 1 deletion packages/flame_lint/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: lib/analysis_options.yaml
include: lib/analysis_options_with_dcm.yaml
10 changes: 10 additions & 0 deletions packages/flame_lint/lib/analysis_options_with_dcm.yaml
View file
Open in desktop
@@ -0,0 +1,10 @@
include: analysis_options.yaml

# DCM rules defined here: https://dcm.dev/docs/rules/

dart_code_metrics:
rules:
# dart rules
- avoid-banned-imports
# flutter rules
- prefer-define-hero-tag
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the first for each from the all preset

2 changes: 1 addition & 1 deletion packages/flame_lottie/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame_lottie/example/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame_network_assets/analysis_options.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml

linter:
rules:
Expand Down
2 changes: 1 addition & 1 deletion packages/flame_network_assets/example/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame_noise/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame_oxygen/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame_rive/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame_rive/example/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame_spine/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame_spine/example/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame_studio/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame_svg/analysis_options.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml

linter:
rules:
Expand Down
2 changes: 1 addition & 1 deletion packages/flame_svg/example/analysis_options.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml

linter:
rules:
Expand Down
2 changes: 1 addition & 1 deletion packages/flame_test/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame_tiled/analysis_options.yaml
View file
Open in desktop
@@ -1 +1 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml
2 changes: 1 addition & 1 deletion packages/flame_tiled/example/analysis_options.yaml
View file
Open in desktop
@@ -1,4 +1,4 @@
include: package:flame_lint/analysis_options.yaml
include: package:flame_lint/analysis_options_with_dcm.yaml

linter:
rules:
Expand Down