fix(flame): Export FixedResolutionViewport and make withFixedResolution a redirect constructor
#2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ution` a redirect constructor
wolfenrain
requested review from
spydon,
erickzanardo,
luanpotter and
renancaraujo
spydon
approved these changes
Oct 13, 2023
spydon
deleted the
fix(flame)-export-`FixedResolutionViewport`-and-make-`withFixedResolution`-a-redirect-constructor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
CameraComponent.withFixedResolutionwas a factory but can easily be a redirect constructor, allowing developers to use it when they extend theCameraComponent. On top of that theFixedResolutionViewportwas not being exported so if a developer wanted to have a custom camera with aFixedResolutionViewportthere was no way to do so unless they imported fromsrc/or copied the code, both are bad practices 😄Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues