Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Minor issues due Flutter 3.16 #2856

Merged
merged 6 commits into from Nov 16, 2023
Merged

fix: Minor issues due Flutter 3.16 #2856

merged 6 commits into from Nov 16, 2023

Conversation

erickzanardo
Copy link
Member

@erickzanardo erickzanardo commented Nov 16, 2023

Description

With the last Flutter version, a few issues were introduced in Flame sourcebase. This PR solves that.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Replace or remove this text.

@erickzanardo erickzanardo requested a review from a team November 16, 2023 18:02
@erickzanardo erickzanardo changed the title feat: minor issues due Flutter 3.16 feat: Minor issues due Flutter 3.16 Nov 16, 2023
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erickzanardo erickzanardo marked this pull request as draft November 16, 2023 18:42
@spydon spydon changed the title feat: Minor issues due Flutter 3.16 fix: Minor issues due Flutter 3.16 Nov 16, 2023
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@@ -5,7 +5,7 @@ publish_to: 'none'
version: 1.0.0+1

environment:
sdk: '>=2.18.0 <4.0.0'
sdk: ">=3.0.0 <4.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add this to melos.yaml so that it can be set for all packages at once

@erickzanardo erickzanardo marked this pull request as ready for review November 16, 2023 20:50
@erickzanardo erickzanardo merged commit d51cd58 into main Nov 16, 2023
9 checks passed
@erickzanardo erickzanardo deleted the feat/flutter-3.16 branch November 16, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants