Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Minor issues due Flutter 3.16 #2856

Merged
merged 6 commits into from Nov 16, 2023
Merged

fix: Minor issues due Flutter 3.16 #2856

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
12140d6
feat: minor issues due Flutter 3.16
erickzanardo Nov 16, 2023
d4ee03a
fix format
erickzanardo Nov 16, 2023
27e3266
deprecation fix
erickzanardo Nov 16, 2023
09c66c3
fixing ci version
erickzanardo Nov 16, 2023
74ecb36
fixing tests
erickzanardo Nov 16, 2023
5f2574d
fixing goldens tests because linux > macos
erickzanardo Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/lib/stories/bridge_libraries/flame_forge2d/widget_example.dart
View file
Open in desktop
Expand Up @@ -127,7 +127,7 @@
},
child: const Text(
'Flying button!',
textScaleFactor: 2.0,
textScaler: TextScaler.linear(2.0),

Check failure on line 130 in examples/lib/stories/bridge_libraries/flame_forge2d/widget_example.dart

View workflow job for this annotation

GitHub Actions / analyze

The named parameter 'textScaler' isn't defined. 

Try correcting the name to an existing named parameter's name, or defining a named parameter with the name 'textScaler'.
See https://dart.dev/diagnostics/undefined_named_parameter to learn more about this problem.

Check failure on line 130 in examples/lib/stories/bridge_libraries/flame_forge2d/widget_example.dart

View workflow job for this annotation

GitHub Actions / analyze

Undefined name 'TextScaler'. 

Try correcting the name to one that is defined, or defining the name.
See https://dart.dev/diagnostics/undefined_identifier to learn more about this problem.
),
),
),
Expand Down
4 changes: 2 additions & 2 deletions packages/flame/lib/src/experimental/geometry/shapes/rounded_rectangle.dart
View file
Open in desktop
Expand Up @@ -178,8 +178,8 @@ class RoundedRectangle extends Shape {
@override
Vector2 nearestPoint(Vector2 point) {
_tmpResult.setValues(
(point.x).clamp(_left, _right),
(point.y).clamp(_top, _bottom),
point.x.clamp(_left, _right),
point.y.clamp(_top, _bottom),
);
if (containsPoint(_tmpResult)) {
return _tmpResult;
Expand Down
7 changes: 6 additions & 1 deletion packages/flame/test/game/game_render_box_test.dart
View file
Open in desktop
Expand Up @@ -9,7 +9,12 @@ class _MockFlameGame extends Mock implements FlameGame {}

class _MockBuildContext extends Mock implements BuildContext {}

class _MockPipelineOwner extends Mock implements PipelineOwner {}
class _MockPipelineOwner extends Mock implements PipelineOwner {
@override
String toString({DiagnosticLevel minLevel = DiagnosticLevel.info}) {
return '';
}
}

final nodesNeedingCompositingBitsUpdate = <RenderObject>[];

Expand Down