Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Using viewport scale on debug mode text paint #2883

Merged
merged 1 commit into from Nov 29, 2023
Merged

feat: Using viewport scale on debug mode text paint #2883

merged 1 commit into from Nov 29, 2023

Conversation

erickzanardo
Copy link
Member

@erickzanardo erickzanardo commented Nov 29, 2023 •
edited

Description

Consider viewport scaling into the text paint used in the debug information of components.

Fixes #2881

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Replace or remove this text.

@erickzanardo erickzanardo requested a review from a team November 29, 2023 16:09
spydon
spydon approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@erickzanardo erickzanardo merged commit 07ef46c into main Nov 29, 2023
9 checks passed
@erickzanardo erickzanardo deleted the erick.viewport-at-debug branch November 29, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@renancaraujo renancaraujo renancaraujo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

debugTextPaing should take viewport into the consideration.
3 participants
@erickzanardo @spydon @renancaraujo