Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Image layers repeat indefinitely if repeated in Tiled #2921

Merged
merged 4 commits into from
Dec 17, 2023
Merged

fix: Image layers repeat indefinitely if repeated in Tiled #2921

merged 4 commits into from
Dec 17, 2023

Conversation

kurtome
Copy link
Contributor

@kurtome kurtome commented Dec 15, 2023

Description

Fix for #2777, images repeat along the selected axis forever in both directions. This matches the Tiled behavior.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #2777

spydon
spydon approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, quite similar to the logic in the parallax

ufrshubham
ufrshubham approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@ufrshubham ufrshubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spydon spydon enabled auto-merge (squash) December 17, 2023 13:22
@spydon spydon merged commit 6f79bc5 into flame-engine:main Dec 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@ufrshubham ufrshubham ufrshubham approved these changes

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flame_tiled] Image layers don't correctly handle repeatX / repeatY setting in the layer
3 participants
@kurtome @spydon @ufrshubham