Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Consider displaced hitboxes in GestureHitboxes mixin #2957

Merged
merged 1 commit into from Jan 4, 2024
Merged

fix: Consider displaced hitboxes in GestureHitboxes mixin #2957

merged 1 commit into from Jan 4, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented Jan 4, 2024

Description

Previously the point sent in to containsLocalPoint for GestureHitboxes didn't take the parent transformation into consideration, this is fixed in this PR.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

@spydon spydon merged commit 1085518 into main Jan 4, 2024
8 checks passed
@spydon spydon deleted the fix/gestures-hitboxes-local branch January 4, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spydon @erickzanardo