feat: Add vector projection and inversion #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
st-pasha
reviewed
Jul 8, 2022
st-pasha
approved these changes
Jul 9, 2022
erickzanardo
approved these changes
Jul 9, 2022
wolfenrain
reviewed
Jul 9, 2022
| /// [other] needs to have a length > 0; | ||
| /// If [out] is specified, it will be used to provide the result. | ||
| Vector2 projection(Vector2 other, {Vector2? out}) { | ||
| assert(other.length2 > 0, 'other needs to have a length > 0'); |
There was a problem hiding this comment.
imho, we should have a test for this assertion as well to ensure it stays
wolfenrain
approved these changes
Jul 9, 2022
st-pasha
pushed a commit
to st-pasha/flame
that referenced
this pull request
Jul 13, 2022
Adding projection, ìnvert and inverted to the vector extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
projection,ìnvertandinvertedto the vector extension.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues