Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add isDragged in DragCallbacks mixin #2472

Merged
merged 3 commits into from Apr 7, 2023
Merged

feat: Add isDragged in DragCallbacks mixin #2472

merged 3 commits into from Apr 7, 2023

Conversation

ufrshubham
Copy link
Collaborator

@ufrshubham ufrshubham commented Apr 7, 2023 •
edited

Description

Adding a isDragged state for DragCallbacks mixin. This was available in the Draggable mixin.

Checklist

  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

NA

spydon
spydon approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I was thinking about this when deprecating the other mixins, but then forgot to implement it. 😅

@ufrshubham
Copy link
Collaborator Author

And I was wondering if there was some problem with the original implementation. As all the places where it was used had implemented their own state variable 😄

@spydon spydon merged commit de630a1 into main Apr 7, 2023
6 checks passed
@spydon spydon deleted the devkage/add-is-dragged branch April 7, 2023 11:39
@gilescm gilescm mentioned this pull request Jul 29, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ufrshubham @spydon