Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add globalToLocal and localToGlobal methods to viewport, viewfinder and camera #2720

Merged
merged 5 commits into from
Sep 10, 2023
Merged

feat: Add globalToLocal and localToGlobal methods to viewport, viewfinder and camera #2720

merged 5 commits into from
Sep 10, 2023

Conversation

luanpotter
Copy link
Member

Description

Add globalToLocal and localToGlobal methods to viewport, viewfinder and camera.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter marked this pull request as ready for review September 10, 2023 19:59
@luanpotter luanpotter changed the title Add globalToLocal and localToGlobal methods to viewport, viewfinder and camera feat: Add globalToLocal and localToGlobal methods to viewport, viewfinder and camera Sep 10, 2023
spydon
spydon approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, possibly could be good with dartdocs, but I think the names are pretty self explanatory?

@luanpotter
Copy link
Member Author

I can add some, doesn't hurt.

@luanpotter luanpotter enabled auto-merge (squash) September 10, 2023 20:29
@luanpotter luanpotter merged commit 00185a3 into main Sep 10, 2023
7 checks passed
@luanpotter luanpotter deleted the luan.camera-project branch September 10, 2023 20:34
@spydon spydon mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luanpotter @spydon