Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add collision completed listener #2896

Merged
merged 24 commits into from
Dec 6, 2023
Merged

feat: Add collision completed listener #2896

merged 24 commits into from
Dec 6, 2023

Commits on Nov 11, 2023

  1. First attempt at creating onCollisionsCompleted

    christian-mindfulness committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    4b8bdd5 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2023

  1. Bug fix which gets things working.

    christian-mindfulness committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    5d42eed View commit details
    Browse the repository at this point in the history

  2. First attempt at adding tests

    christian-mindfulness committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    f4ab7b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Revert "First attempt at adding tests" 

    This reverts commit f4ab7b9.
    christian-mindfulness committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    76d2970 View commit details
    Browse the repository at this point in the history

  2. Revert "First attempt at creating onCollisionsCompleted" 

    This reverts commit 4b8bdd5.
    christian-mindfulness committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    1216440 View commit details
    Browse the repository at this point in the history

  3. Revert "Bug fix which gets things working." 

    This reverts commit 5d42eed.
    christian-mindfulness committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    e9dba44 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2023

  1. Add ChangeNotifier to collision detection.

    christian-mindfulness committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    d49d3da View commit details
    Browse the repository at this point in the history

  2. Add an override of the ChaneNotifier class and start documentation.

    christian-mindfulness committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    05db541 View commit details
    Browse the repository at this point in the history

  3. Add a description of new ChangeNotifier override.

    christian-mindfulness committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    015f9bd View commit details
    Browse the repository at this point in the history

  4. Remove changes from shape hitbox.

    christian-mindfulness committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    92eb7c5 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Switch from ChangeNotifier to implementing Listenable.

    christian-mindfulness committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e6256db View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Merge branch 'main' into add_collision_completed

    christian-mindfulness committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    09fec9c View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Update comment for Listener class

    christian-mindfulness committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    21e8725 View commit details
    Browse the repository at this point in the history

  2. Fix markdown lint failure

    christian-mindfulness committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    362ad63 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. Merge branch 'main' into add_collision_completed

    @christian-mindfulness
    christian-mindfulness committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    82b6745 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Update packages/flame/lib/src/collisions/collision_detection.dart 

    comment change

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
    @christian-mindfulness @spydon
    christian-mindfulness and spydon committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    9d74231 View commit details
    Browse the repository at this point in the history

  2. Change name of notifier, as requested in review

    christian-mindfulness committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    834c950 View commit details
    Browse the repository at this point in the history

  3. Notify class inherits from ChangeNotifier, rather than Listenable.

    christian-mindfulness committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    2b9c946 View commit details
    Browse the repository at this point in the history

  4. Add first version of notifier test.

    christian-mindfulness committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    66879ca View commit details
    Browse the repository at this point in the history

  5. Bug fix on flame test.

    christian-mindfulness committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    8e16121 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Fixes following @spydon's review.

    christian-mindfulness committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    6b779c2 View commit details
    Browse the repository at this point in the history

  2. Fix change notifier.

    christian-mindfulness committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    13b3905 View commit details
    Browse the repository at this point in the history

  3. Update formatting in docs

    christian-mindfulness committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    2f9fc20 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into add_collision_completed

    @spydon
    spydon committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    a9308c9 View commit details
    Browse the repository at this point in the history