Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add children to SpriteAnimationComponent.fromFrameData #2914

Merged
merged 1 commit into from
Dec 9, 2023
Merged

feat: Add children to SpriteAnimationComponent.fromFrameData #2914

merged 1 commit into from
Dec 9, 2023

Conversation

ufrshubham
Copy link
Collaborator

@ufrshubham ufrshubham commented Dec 9, 2023 •
edited

Description

Just exposed the children list from fromFrameData constructor.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

spydon
spydon approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@spydon spydon merged commit caf2b90 into main Dec 9, 2023
9 checks passed
@spydon spydon deleted the devkage/sprite-animation-component-children branch December 9, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ufrshubham @spydon