Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Misalignment of the hittest area of PolygonHitbox #2930

Merged
merged 6 commits into from
Dec 17, 2023
Merged

fix: Misalignment of the hittest area of PolygonHitbox #2930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f7a8145
fix calculation for point hittest of PolygonComponent
organic-nailer Dec 17, 2023
5171749
Merge branch 'main' of https://github.com/flame-engine/flame
organic-nailer Dec 17, 2023
f662016
add test
organic-nailer Dec 17, 2023
c2388dd
fix word
organic-nailer Dec 17, 2023
257dc38
fix test and format
organic-nailer Dec 17, 2023
da02f2b
Merge branch 'main' into main
spydon Dec 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/flame/lib/src/geometry/polygon_component.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,8 @@ class PolygonComponent extends ShapeComponent {
}
for (var i = 0; i < _vertices.length; i++) {
final edge = getEdge(i, vertices: vertices);
final isOutside = (edge.to.x - edge.from.x) *
(point.y - edge.from.y + _topLeft.y) -
(point.x - edge.from.x + _topLeft.x) * (edge.to.y - edge.from.y) >
final isOutside = (edge.to.x - edge.from.x) * (point.y - edge.from.y) -
(point.x - edge.from.x) * (edge.to.y - edge.from.y) >
0;
if (isOutside) {
return false;
Expand Down
13 changes: 13 additions & 0 deletions packages/flame/test/components/shape_component_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,19 @@ void main() {
);
});

test('polygon contains point in local', () {
final polygon = PolygonComponent(
[
Vector2(0.5, 0.5),
Vector2(0.5, 1.5),
Vector2(1.5, 1.5),
Vector2(1.5, 0.5),
],
);
expect(polygon.containsLocalPoint(Vector2(0.25, 0.25)), isFalse);
expect(polygon.containsLocalPoint(Vector2(0.75, 0.75)), isTrue);
});

test('rotated circle does not contain point', () {
final component = CircleComponent(
radius: 1.0,
Expand Down