Added typed properties support and properties for TileMap and Layer #3
Conversation
lib/src/tile_map_parser.dart
Outdated
| final a = value.substring(1, 3); | ||
| final rgb = value.substring(3); | ||
|
|
||
| map[name] = '#' + rgb + a; |
There was a problem hiding this comment.
I'm not sure what this color type entails but on Flame/Flutter we often use colors as ARGB, not RGBA. (eg Color class constructor)
There was a problem hiding this comment.
Is there method to check if environment is web? And then optional parse to RGBA. In web ARGB is useless.
There was a problem hiding this comment.
hum I thought dart would standardize that... let's leave this as is but please add a todo comment, it's clearly an edge case and we can study this later. but I prefer to follow dart conventions, flutter-web should be translating whatever it needs.
|
@luanpotter I added commit with changes. |
lib/src/layer.dart
Outdated
|
|
||
| properties = TileMapParser._parseProperties( | ||
| TileMapParser._getPropertyNodes(element), | ||
| ); |
There was a problem hiding this comment.
it seems it would be useful to have a TileMapParser._parsePropertiesFromXML method to be used in 3 places
There was a problem hiding this comment.
We need to add an entry to the CHANGELOG and finish these missing comments by @luanpotter
No description provided.