Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding a method to get any object in a map by its unique ID #75

Merged
merged 2 commits into from
Dec 6, 2023
Merged

feat: Adding a method to get any object in a map by its unique ID #75

merged 2 commits into from
Dec 6, 2023

Conversation

kurtome
Copy link
Collaborator

@kurtome kurtome commented Dec 5, 2023

Description

Adding a method to get any object in a map by its unique ID, map.objectById

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
  • I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

spydon
spydon approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@kurtome
Copy link
Collaborator Author

kurtome commented Dec 6, 2023

@spydon I think this is ready to merge 👍 , I don't have access on this repo

@spydon spydon merged commit 4faf43b into flame-engine:main Dec 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@ufrshubham ufrshubham ufrshubham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kurtome @spydon @ufrshubham