-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for building on OS X #28
Conversation
…lang configuration
…r functions (as well as performing a few minor modifications of the pthreads code)
This looks good to me but I have not tested. @fgvanzee Would you like me test locally? I recall you may be a "serious programmer" (Linux laptop person). |
Is the new osx configuration only due to |
@Maratyszcza I believe that was the only change I made to |
@fgvanzee Maybe multithreading model should be an argument to |
@Maratyszcza Agreed; in this case, it's a matter of compiler support. |
Is this still an issue? I can't cleanly merge this PR with the latest master and I wonder if it needs to be sorted out or not. |
Is the only issue that it doesn't work "out of the box" with Apple's version of gcc/llvm (due do missing pthread_barrier)? If so we have a non-pthread barrier already that could be hooked up easily. The so/dyld stuff could be helpful but the linker manages to figure out what you mean with .so as far as I can tell. I don't think the sandybridge_osx_clang configuration stuff is necessary with various new configure options. On the other hand, if we are fine not supporting Apple's gimped compilers then I think there is nothing to do at this point. |
It is worth adding the workaround for missing |
@tlrmchlsmth I think you have the skillz to pay the billz on this one. |
Actually I already fixed the pthread barrier thing but I didn't know this issue was here. |
I guess it can be resolved although it's good to setup Mac builds in Travis If Mac is tested in Travis already, I apologize. I'm not using a client Jeff Hammond |
Obsoleted by #108. |
In addition to creating a new profile,
sandybridge_osx_clang
, I have finished working around the missingpthread_barrier
functionality and generalized the build system to support more general shared and static library suffixes (e.g., .dylib for shared libraries on OS X). Lastly, I enabled shared-library builds by default in each of the configurations.