chore: fix linter errors (#147)

.golangci.yml

@@ -4,16 +4,13 @@ linters-settings:
 
 linters:
   enable:
-    - deadcode
+    - unused
     - errcheck
     - gosimple
     - govet
     - ineffassign
     - staticcheck
-    - structcheck
     - typecheck
-    - unused
-    - varcheck
     - nakedret
     - gofmt
     - rowserrcheck

recovery.go

@@ -7,9 +7,9 @@ package flamego
 import (
 	"bytes"
 	"fmt"
-	"io/ioutil"
 	"log"
 	"net/http"
+	"os"
 	"runtime"
 
 	"github.com/flamego/flamego/inject"
@@ -109,7 +109,7 @@ pre {
 			// Print this much at least.  If we can't find the source, it won't show.
 			_, _ = fmt.Fprintf(buf, "%s:%d (0x%x)\n", file, line, pc)
 			if file != lastFile {
-				data, err := ioutil.ReadFile(file)
+				data, err := os.ReadFile(file)
 				if err != nil {
 					continue
 				}

router.go

@@ -145,11 +145,12 @@ type Route struct {
 // addition to the request path.
 //
 // For example:
-//  f.Get("/", ...).Headers(
-//      "User-Agent", "Chrome",   // Loose match
-//      "Host", "^flamego\.dev$", // Exact match
-//      "Cache-Control", "",      // As long as "Cache-Control" is not empty
-//  )
+//
+//	f.Get("/", ...).Headers(
+//	    "User-Agent", "Chrome",   // Loose match
+//	    "Host", "^flamego\.dev$", // Exact match
+//	    "Cache-Control", "",      // As long as "Cache-Control" is not empty
+//	)
 //
 // Subsequent calls to Headers() replace previously set matches.
 func (r *Route) Headers(pairs ...string) *Route {

static_test.go

@@ -25,7 +25,7 @@ func TestStatic(t *testing.T) {
 
 	t.Run("serve with GET", func(t *testing.T) {
 		resp := httptest.NewRecorder()
-		req, err := http.NewRequest(http.MethodGet, "/.editorconfig", nil)
+		req, err := http.NewRequest(http.MethodGet, "/.editorconfig", http.NoBody)
 		assert.Nil(t, err)
 
 		f.ServeHTTP(resp, req)
@@ -37,7 +37,7 @@ func TestStatic(t *testing.T) {
 
 	t.Run("serve with HEAD", func(t *testing.T) {
 		resp := httptest.NewRecorder()
-		req, err := http.NewRequest(http.MethodHead, "/.editorconfig", nil)
+		req, err := http.NewRequest(http.MethodHead, "/.editorconfig", http.NoBody)
 		assert.Nil(t, err)
 
 		f.ServeHTTP(resp, req)
@@ -49,7 +49,7 @@ func TestStatic(t *testing.T) {
 
 	t.Run("404 with POST", func(t *testing.T) {
 		resp := httptest.NewRecorder()
-		req, err := http.NewRequest(http.MethodPost, "/.editorconfig", nil)
+		req, err := http.NewRequest(http.MethodPost, "/.editorconfig", http.NoBody)
 		assert.Nil(t, err)
 
 		f.ServeHTTP(resp, req)
@@ -73,7 +73,7 @@ func TestStatic_Options(t *testing.T) {
 		))
 
 		resp := httptest.NewRecorder()
-		req, err := http.NewRequest(http.MethodGet, "/hello.txt", nil)
+		req, err := http.NewRequest(http.MethodGet, "/hello.txt", http.NoBody)
 		assert.Nil(t, err)
 
 		f.ServeHTTP(resp, req)
@@ -142,7 +142,7 @@ func TestStatic_Options(t *testing.T) {
 				))
 
 				resp := httptest.NewRecorder()
-				req, err := http.NewRequest(http.MethodHead, "/", nil)
+				req, err := http.NewRequest(http.MethodHead, "/", http.NoBody)
 				assert.Nil(t, err)
 
 				f.ServeHTTP(resp, req)
@@ -164,7 +164,7 @@ func TestStatic_Options(t *testing.T) {
 		))
 
 		resp := httptest.NewRecorder()
-		req, err := http.NewRequest(http.MethodHead, "/.editorconfig", nil)
+		req, err := http.NewRequest(http.MethodHead, "/.editorconfig", http.NoBody)
 		assert.Nil(t, err)
 
 		f.ServeHTTP(resp, req)
@@ -205,7 +205,7 @@ func TestStatic_Options(t *testing.T) {
 		))
 
 		resp := httptest.NewRecorder()
-		req, err := http.NewRequest(http.MethodGet, "/.editorconfig", nil)
+		req, err := http.NewRequest(http.MethodGet, "/.editorconfig", http.NoBody)
 		assert.Nil(t, err)
 
 		f.ServeHTTP(resp, req)
@@ -229,7 +229,7 @@ func TestStatic_Options(t *testing.T) {
 		))
 
 		resp := httptest.NewRecorder()
-		req, err := http.NewRequest(http.MethodGet, "/.editorconfig", nil)
+		req, err := http.NewRequest(http.MethodGet, "/.editorconfig", http.NoBody)
 		assert.Nil(t, err)
 
 		f.ServeHTTP(resp, req)
@@ -260,7 +260,7 @@ func TestStatic_Redirect(t *testing.T) {
 		))
 
 		resp := httptest.NewRecorder()
-		req, err := http.NewRequest(http.MethodGet, "/public/", nil)
+		req, err := http.NewRequest(http.MethodGet, "/public/", http.NoBody)
 		assert.Nil(t, err)
 
 		f.ServeHTTP(resp, req)
@@ -278,7 +278,7 @@ func TestStatic_Redirect(t *testing.T) {
 		))
 
 		resp := httptest.NewRecorder()
-		req, err := http.NewRequest(http.MethodGet, "/public", nil)
+		req, err := http.NewRequest(http.MethodGet, "/public", http.NoBody)
 		assert.Nil(t, err)
 
 		f.ServeHTTP(resp, req)
@@ -292,7 +292,7 @@ func TestStatic_Redirect(t *testing.T) {
 		f.Use(Static())
 
 		resp := httptest.NewRecorder()
-		req, err := http.NewRequest(http.MethodGet, "http://localhost:2830//example.com%2f..", nil)
+		req, err := http.NewRequest(http.MethodGet, "http://localhost:2830//example.com%2f..", http.NoBody)
 		assert.Nil(t, err)
 
 		f.ServeHTTP(resp, req)