Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drift variable guarding #14

Open
ptheywood opened this issue Jan 25, 2022 · 0 comments
Open

Drift variable guarding #14

ptheywood opened this issue Jan 25, 2022 · 0 comments

Comments

@ptheywood
Copy link
Member

The drift member variable is guarded out differently between the implementations.

circles_spatial3D guards out the member variable entirely if the macro is not defined to a non negative integer.

The 3 other implementations do not guard out the member variable.

This should be standardised to make performance comparisons fair, either to keep it on in all or guard it out in all. RTC makes guarding it out more fun.

Additionally, brute force and spatial do not compute the number of messages the same. For fairness of perforamnce benchmarks this should only be tracked if enabled, or bruteforce should perform the unnneccesary increment operator per message, but this will harm performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant