Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass in option --open to automatically open the resulting #45

Merged
merged 8 commits into from
Dec 18, 2019

Conversation

VersBinarii
Copy link
Contributor

.svg file in the default program. Its similar operation to the cargo doc --open

Cargo.toml Outdated Show resolved Hide resolved
src/bin/cargo-flamegraph.rs Outdated Show resolved Hide resolved
src/bin/cargo-flamegraph.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and sorry for the delay in reviewing this! This looks like a reasonable addition to me. If you can rebase this onto the current master I'll take another look. Thanks!

src/bin/cargo-flamegraph.rs Outdated Show resolved Hide resolved
@VersBinarii
Copy link
Contributor Author

Hello,
Sorry, it got a little messy with the rebasing. Hope all is fine now.

Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! Left a few more comments, then this should be good to go.

src/bin/cargo-flamegraph.rs Outdated Show resolved Hide resolved
src/bin/flamegraph.rs Outdated Show resolved Hide resolved
src/bin/cargo-flamegraph.rs Outdated Show resolved Hide resolved
src/bin/flamegraph.rs Outdated Show resolved Hide resolved
@jonas-schievink
Copy link
Contributor

Great, thanks!

@jonas-schievink jonas-schievink merged commit e4ae6c8 into flamegraph-rs:master Dec 18, 2019
@VersBinarii VersBinarii deleted the open_arg branch March 14, 2020 20:25
leod pushed a commit to leod/flamegraph that referenced this pull request Jun 3, 2023
…lamegraph-rs#45)

* Allow to pass in option --open to automatically open the resulting
.svg file in the default program

* Modify according to the comments

* Use only long argument

* No need for a clone

* Error implements Display trait
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants