rename Imgur API Key to Imgur Application Client ID #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the translation should be changed as well. that is it of the scope of this PR, but I think the translations should be wiped so that the get redone by the community |
|
I did change the existing English versions of the phrase, but feel
completely unqualified to actually translate the term in other languages.
I don't think that should hold up this PR, as it looks like quite a bit of
the translation for that phrase is still incomplete.
…On Fri, Jun 24, 2022, 1:53 PM Mehrad Mahmoudian ***@***.***> wrote:
I think the translation should be changed as well. that is it of the scope
of this PR, but I think the translations should be wiped so that the get
redone by the community
—
Reply to this email directly, view it on GitHub
<#2719 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKV7GO2JWWHLQDI5X3I2TVQXY2XANCNFSM5ZYOHKGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I agree that translation is not the point of this PR, all I'm saying is that should we remove the translations so that they are marked to be translated in weblet? I don't know the procedure and that's why I'm raising the concern here. @borgmanJeremy knows best I guess |
|
Makes sense. I'd still vote that removal should be a separate PR, just to keep it clean. |
|
In general we should NOT refresh the .ts files, but ill merge this as is. |
panpuchkov
pushed a commit
to namecheap/flameshot
that referenced
this pull request
Sep 9, 2022
(cherry picked from commit 13c034c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #2718
I didn't mess with the translations other than the rename.