fix: workaround macos fullscreen animation #3625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be introduced in macOS 11 or 12, where the API that showFullScreen plays an animation. The downside of this approach is the system menu bar is still visible while taking a screenshot, as the window is no longer actually fullscreen, just borderless covering the screen.
|
Do I understand it correctly that this PR makes Flameshot to be a "maximized" window but not a full-screen one? |
|
I believe this would also fix the issue from #2612 as not capturing the menu bar, for me it would be worth to lose the feature to capture the menu bar but if anybody has a solution how this could be fixed without losing this feature would be nice. |
|
Thanks for the initiative! I would like to suggestions from the community on what other OSS screenshot tooling is there that does this correctly? Maybe then we could see what API or techniques they use. |
mmahmoudian
added
Waiting For Info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would resolve #2886 at the cost of the system menu bar not being able to be visible as part of the capture window.
If there is something available in QT to put the window above the menu bar or disable the animation, we should use that instead. I couldn't find an API to do that though -- I feel like i0t has to be possible somehow, since the built-in screenshot command does not have this issue, and System Settings is able to draw overlays that are placed on top of the menu bar (if you have multiple monitors and re-arrange them, a red border surrounds the screen); Maybe this API is reserved for the system apps?
For now, I find this trade off reasonable as the fullscreen exit animation as shown in the issue is incredibly annoying, and most screenshots do not need to annotate the menu bar (you can still screenshot it, but the system bar is in the way for annotations).