[AsmPrinter] Fix redundant names and types #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug was introduced in 82b38d2 while cherry-picking a DIGlobalVariable-related patch.
kiranchandramohan
approved these changes
Feb 17, 2021
|
This also fixed the llvm tests for me. clang tests are failing, but another PR should fix them. @kiranchandramohan , yes, this is only an issue for release_11x branch. CI won't pass without #16 (mainly without the branch name update from So we can either merge this without looking at the test failures and then I will rebase my changes on top of this and hopefully get the CI green. Alternatively we can ask Bryan to amend this PR with the branch update and other commits from llvm-project origin. |
|
Feel free to pick this into your PR and we can close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was introduced in 82b38d2 while
cherry-picking a DIGlobalVariable-related patch.