Update TargetRewrite after upstreaming #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanPerier
approved these changes
Nov 9, 2021
|
I don't have permissions to merge this, could someone else please push the button? :) |
schweitzpgi
reviewed
Nov 9, 2021
| auto mod = getModule(); | ||
| if (!forcedTargetTriple.empty()) { | ||
| setTargetTriple(mod, forcedTargetTriple); | ||
| } |
There was a problem hiding this comment.
They're not in LLVM, but I think they are in flang:
f18-llvm-project/flang/docs/C++style.md
Line 117 in 1fe8993
There was a problem hiding this comment.
files in the Optimizer directory are actually following the MLIR guidelines (see note in header in this file).
There was a problem hiding this comment.
Riiight, I completely forgot about that.
There was a problem hiding this comment.
No worries. Hard to keep track of the different flavor sometimes :-)
rovka
added a commit
to llvm/llvm-project
that referenced
this pull request
Nov 15, 2021
Clarify some comments as discussed here: flang-compiler#1210
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Clarify some comments as discussed here: flang-compiler/f18-llvm-project#1210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port back some of the changes made to the code while upstreaming TargetRewrite. Note that the upstreaming of TargetRewrite is not yet complete (I'm working on one more patch for AddrOf).