Add location to some lowering TODOs that missed it #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve TODO messages: - `genLocation()` was used instead of `getCurrentLocation` in many places that intended to print the current location. - Thread/Compute the location when possible instead of using TODO_NOLOC. - Ensure the location is set when entering not yet implemented constructs (toLocation() might return an empty location in case the construct is the first of an anonymous program)
schweitzpgi
approved these changes
Jan 13, 2022
psteinfeld
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve TODO messages:
genLocation()was used instead ofgetCurrentLocationin many places thatintended to print the current location and not an unknown one.
constructs (toLocation() might return an empty location in case the
construct is the first of an anonymous program)