Relpace LoopOp Op with DoLoopOp Op in FIR Dialect
#296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schweitzpgi
reviewed
Jul 22, 2020
flang/documentation/BurnsideToFIR.md
Outdated
| @@ -428,7 +428,7 @@ Fortran into FIR in a semantics preserving way. | |||
| // create a temporary to hold E(V) | |||
| %v = ... : !fir.array<4:i32> | |||
| %8 = fir.alloca !fir.array<4:f32> : !fir.ref<!fir.array<4:f32>> | |||
| fir.loop %i = %c1 to %c4 unordered { | |||
| fir.doloop %i = %c1 to %c4 unordered { | |||
There was a problem hiding this comment.
Should be do_loop in the syntactic form like this. Although the _ is omitted in the camelcase class name.
schweitzpgi
reviewed
Jul 22, 2020
| @@ -17,7 +17,7 @@ | |||
| include "mlir/Pass/PassBase.td" | |||
|
|
|||
| def AffineDialectPromotion : FunctionPass<"promote-to-affine"> { | |||
| let summary = "Promotes fir.loop and fir.where to affine.for and affine.if where possible"; | |||
| let summary = "Promotes fir.doloop and fir.where to affine.for and affine.if where possible"; | |||
schweitzpgi
reviewed
Jul 22, 2020
flang/lib/Lower/Bridge.cpp
Outdated
| @@ -813,11 +813,11 @@ class FirConverter : public Fortran::lower::AbstractConverter { | |||
| assert(info.stepValue && "step value must be set"); | |||
| info.loopVariable = createTemp(loc, *info.loopVariableSym); | |||
|
|
|||
| // Structured loop - generate fir.loop. | |||
| // Structured loop - generate fir.doloop. | |||
schweitzpgi
reviewed
Jul 22, 2020
flang/lib/Lower/Bridge.cpp
Outdated
| @@ -864,7 +864,7 @@ class FirConverter : public Fortran::lower::AbstractConverter { | |||
| void genFIRIncrementLoopEnd(IncrementLoopInfo &info) { | |||
| auto loc = toLocation(); | |||
| if (info.isStructured()) { | |||
| // End fir.loop. | |||
| // End fir.doloop. | |||
schweitzpgi
reviewed
Jul 22, 2020
| @@ -362,17 +362,17 @@ void rewriteMemoryOps(Block *block, mlir::PatternRewriter &rewriter) { | |||
| } | |||
| } | |||
|
|
|||
| /// Convert `fir.loop` to `affine.for`, creates fir.convert for arrays to | |||
| /// Convert `fir.doloop` to `affine.for`, creates fir.convert for arrays to | |||
schweitzpgi
reviewed
Jul 22, 2020
| @@ -496,7 +496,7 @@ class AffineIfConversion : public mlir::OpRewritePattern<fir::IfOp> { | |||
| AffineFunctionAnalysis &functionAnalysis; | |||
| }; | |||
|
|
|||
| /// Promote fir.loop and fir.if to affine.for and affine.if, in the cases | |||
| /// Promote fir.doloop and fir.if to affine.for and affine.if, in the cases | |||
SouraVX
force-pushed
the
Replace-LoopOp-to-DoLoopOp
branch
from
346e670
to
6e64fa8
Compare
|
Done! |
schweitzpgi
approved these changes
Jul 22, 2020
SouraVX
added a commit
to llvm/llvm-project
that referenced
this pull request
Feb 3, 2021
Part of upstreaming effort, PR: flang-compiler#296 Reviewed By: schweitz Differential Revision: https://reviews.llvm.org/D95950
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Part of upstreaming effort, PR: flang-compiler/f18-llvm-project#296 Reviewed By: schweitz Differential Revision: https://reviews.llvm.org/D95950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.