Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic checks C8104, C8105. Add tests for C8103, C8104, C8105 #1037

Merged
merged 1 commit into from Feb 28, 2020

Conversation

vjayathirtha-nv
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@kiranchandramohan kiranchandramohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be in check-declarations.cpp?

lib/Semantics/check-namelist.cpp Outdated Show resolved Hide resolved
@vjayathirtha-nv
Copy link
Collaborator Author

Can this be in check-declarations.cpp?

That was my initial choice, but in check-declarations.cpp we don't have access to source location information to point the error at the right place. So I had to make a separate checker.

Copy link
Collaborator

@psteinfeld psteinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, tests, and looks good!

lib/Semantics/check-namelist.cpp Outdated Show resolved Hide resolved
@vjayathirtha-nv vjayathirtha-nv merged commit f2a4e5c into flang-compiler:master Feb 28, 2020
swift-ci pushed a commit to apple/llvm-project that referenced this pull request Apr 9, 2020
swift-ci pushed a commit to apple/llvm-project that referenced this pull request Apr 9, 2020
…nv/master

Add semantic checks C8104, C8105. Add tests for C8103, C8104, C8105

Original-commit: flang-compiler/f18@f2a4e5c
Reviewed-on: flang-compiler/f18#1037
mem-frob pushed a commit to draperlaboratory/hope-llvm-project that referenced this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants