C1167 : Check for exit statments in do-concurrent #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the copyrights on all of the test files are out of date. |
kiranchandramohan
force-pushed
the
c1167
branch
from
a3eeb5d
to
6bec0e2
Compare
Thanks @psteinfeld. Updated. |
klausler
approved these changes
Mar 20, 2019
schweitzpgi
reviewed
Mar 20, 2019
schweitzpgi
reviewed
Mar 20, 2019
schweitzpgi
reviewed
Mar 20, 2019
schweitzpgi
approved these changes
Mar 20, 2019
tskeith
reviewed
Mar 20, 2019
|
Hi Kiran, thanks for the pull request. I'll merge this commit after the issues raised in the comments are resolved. (The NVIDIA convention has been to approve a pull request with the understanding that issues raised in comments will be addressed or further discussed.) My thought is that the person who opened the issue should resolve the issue, so please respond with more comments and commits. Thanks! |
kiranchandramohan
force-pushed
the
c1167
branch
from
6bec0e2
to
2a99e1e
Compare
|
Thanks @sscalpone. I have now pushed some changes addressing the review comments provided by @klausler , @schweitzpgi and @tskeith. |
|
Thanks for resolving all of my comments. |
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Addresses flang-compiler/f18#288 Original-commit: flang-compiler/f18@2a99e1e Reviewed-on: flang-compiler/f18#345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #288