Allow forward references to procedure interfaces in derived types (fi… #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskeith
reviewed
Jul 16, 2019
| Say(symbol.name(), | ||
| "The interface of '%s' (%s) is not an abstract interface or a " | ||
| "procedure with an explicit interface"_err_en_US, | ||
| symbol.name(), interface->name()); |
There was a problem hiding this comment.
I think the interface name should be in quotes too, since it's a name from the user program.
tskeith
approved these changes
Jul 16, 2019
|
Also fixes #579. |
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
…ypes (fixing flang-compiler/f18#571 more) Original-commit: flang-compiler/f18@c1aeeae Reviewed-on: flang-compiler/f18#580 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@eefbcdc Reviewed-on: flang-compiler/f18#580 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@f5c4629 Reviewed-on: flang-compiler/f18#580
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
…/pmk-fixes Allow forward references to procedure interfaces in derived types (fi… Original-commit: flang-compiler/f18@8c63aa9 Reviewed-on: flang-compiler/f18#580
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
…ypes (fixing flang-compiler/f18#571 more) Original-commit: flang-compiler/f18@c1aeeae Reviewed-on: flang-compiler/f18#580 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@eefbcdc Reviewed-on: flang-compiler/f18#580 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@f5c4629 Reviewed-on: flang-compiler/f18#580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…xing #571 more)
An earlier change fixed up forward references in
procedure()interfaces outside derived types. This change completes the job so that forward references can also be used within derived types.